From c7b8f534a7e2f256e0e9ec1eb9b93c8ef80658dc Mon Sep 17 00:00:00 2001 From: Daniel Carl Date: Sat, 2 Aug 2014 22:23:59 +0200 Subject: [PATCH] Fixed memory leak in prev next pattern validation. --- src/js.c | 2 +- src/setting.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/js.c b/src/js.c index 973dbba..7f4c825 100644 --- a/src/js.c +++ b/src/js.c @@ -49,7 +49,7 @@ gboolean js_eval_file(JSContextRef ctx, const char *file) /** * Evaluates given string as script and return if this call succeed or not. - * On success the given **value pointer is filles with the returned string, + * On success the given **value pointer is filled with the returned string, * else with the exception message. In both cases this must be freed by the * caller if no longer used. */ diff --git a/src/setting.c b/src/setting.c index c9c38c5..e0bf6c0 100644 --- a/src/setting.c +++ b/src/setting.c @@ -800,11 +800,10 @@ static gboolean validate_js_regexp_list(const char *pattern) js = g_strdup_printf("var i;for(i=0;i<[%s].length;i++);", pattern); result = js_eval(webkit_web_frame_get_global_context(frame), js, NULL, &value); g_free(js); + if (!result) { vb_echo(VB_MSG_ERROR, true, "%s", value); - g_free(value); - - return false; } - return true; + g_free(value); + return result; } -- 2.20.1