From: Daniel Carl Date: Fri, 12 May 2017 23:13:58 +0000 (+0200) Subject: Close comments in js on end of line. X-Git-Url: https://git.owens.tech/about.html/about.html/git?a=commitdiff_plain;h=92cac5208efe79135dbbb170669a5e5b63fead4e;p=vimb.git Close comments in js on end of line. The multi line comments /* */ must be closed on the same line. Because the simple script that minifies the scripts a little can only remove those on same line closed comments properly. --- diff --git a/src/scripts/hints.js b/src/scripts/hints.js index d70d3b2..0c13644 100644 --- a/src/scripts/hints.js +++ b/src/scripts/hints.js @@ -291,7 +291,7 @@ var hints = Object.freeze((function(){ }; } - /* Retrun the hint string for a given number based on configured hintkeys */ + /* Return the hint string for a given number based on configured hintkeys */ function getHintString(n) { var res = [], len = config.hintKeys.length; @@ -384,17 +384,14 @@ var hints = Object.freeze((function(){ /* internal used methods */ function open(e, newWin) { - /* We call open() and click() in async mode to avoid return as fast as possible. - * If we don't return immediately, the EvalJS dbus call will probably timeout and cause - * errors. - */ + /* We call open() and click() in async mode to avoid return as fast as possible. */ + /* If we don't return immediately, the EvalJS dbus call will probably timeout and cause */ + /* errors. */ if (newWin && e.hasAttribute('href')) { - /* Since the "noopener" vulnerability thing, it's not possible to set an anchor's - * target to _blank. Therefore, we can't simulate ctrl-click through _blank like we - * used to. Therefore, we limit ourselves to "window.open()" in cases we're firing a - * simple link. In other cases, we fire the even normally. - */ - + /* Since the "noopener" vulnerability thing, it's not possible to set an anchor's */ + /* target to _blank. Therefore, we can't simulate ctrl-click through _blank like we */ + /* used to. Therefore, we limit ourselves to "window.open()" in cases we're firing a */ + /* simple link. In other cases, we fire the even normally. */ window.setTimeout(function() { window.open(e.getAttribute('href'), '_blank'); }, 0