From: Daniel Carl Date: Sat, 18 Jan 2014 23:20:46 +0000 (+0100) Subject: Quickfix for some missing hints on some pages (#62). X-Git-Url: https://git.owens.tech/about.html/about.html/git?a=commitdiff_plain;h=d877e3ccf04d2fd4e8dd3304bf4855328c69c8e6;p=vimb.git Quickfix for some missing hints on some pages (#62). This patch removed the dimension check for the hinted element. There are cases, where the hinted element ha no height but contains dimensioned child nodes. At the moment it's hard to work out the right logic when a none dimensioned hint element should be hinted or not. --- diff --git a/src/hints.js b/src/hints.js index 7c4cef8..8a0ac78 100644 --- a/src/hints.js +++ b/src/hints.js @@ -115,8 +115,7 @@ Object.freeze((function(){ var rect = e.getBoundingClientRect(); if (!rect || rect.top > offsets.bottom || rect.bottom < offsets.top || - rect.left > offsets.right || rect.right < offsets.left || - !rect.width || !rect.height + rect.left > offsets.right || rect.right < offsets.left ) { return false; }