From: Leonardo Taccari <iamleot@gmail.com>
Date: Thu, 25 Oct 2018 11:55:21 +0000 (+0200)
Subject: Always pass NUL-terminated text to command_spawn_editor()
X-Git-Url: https://git.owens.tech/assets/favicon.png/assets/favicon.png/git?a=commitdiff_plain;h=bcaeed1773462e4abcae4e480839ef52f622fefc;p=vimb.git

Always pass NUL-terminated text to command_spawn_editor()

It seems that there is no any guarantee that
webkit_web_resource_get_data_finish() return data that is
NUL-terminated.
---

diff --git a/src/normal.c b/src/normal.c
index 689bf1b..4044409 100644
--- a/src/normal.c
+++ b/src/normal.c
@@ -760,10 +760,13 @@ static void normal_view_source_loaded(WebKitWebResource *resource,
     GAsyncResult *res, Client *c)
 {
     gsize length;
-    guchar *text = NULL;
+    guchar *data = NULL;
+    char *text = NULL;
 
-    text = webkit_web_resource_get_data_finish(resource, res, &length, NULL);
+    data = webkit_web_resource_get_data_finish(resource, res, &length, NULL);
+    text = g_strndup(data, length);
     command_spawn_editor(c, &((Arg){0, (char *)text}), NULL, NULL);
+    g_free(data);
     g_free(text);
 }