From 64d884808f8d932fa9d4b390143f07a3cc3c0ee5 Mon Sep 17 00:00:00 2001 From: Sven Speckmaier Date: Fri, 1 Jun 2018 21:45:54 +0200 Subject: [PATCH] moved id to its own variable to adher to IPO model --- src/input.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/input.c b/src/input.c index 9fbde58..43b0a3c 100644 --- a/src/input.c +++ b/src/input.c @@ -111,6 +111,7 @@ VbResult input_open_editor(Client *c) { static unsigned long element_map_next_key = 1; unsigned long element_map_key = 0; + char *element_id = NULL; char **argv, *file_path = NULL; const char *text = NULL, *id = NULL, *editor_command; int argc; @@ -148,6 +149,8 @@ VbResult input_open_editor(Client *c) char *js_command = g_strdup_printf(JS_SET_EDITOR_MAP_ELEMENT, element_map_key); ext_proxy_eval_script(c, js_command, NULL); g_free(js_command); + } else { + element_id = g_strdup(id); } /* create a temp file to pass text to and from editor */ @@ -185,10 +188,7 @@ VbResult input_open_editor(Client *c) EditorData *data = g_slice_new0(EditorData); data->file = file_path; data->c = c; - if( id && strlen(id) > 0 ) - data->element_id = g_strdup(id); - else - data->element_id = NULL; + data->element_id = element_id; data->element_map_key = element_map_key; g_child_watch_add(pid, (GChildWatchFunc)resume_editor, data); -- 2.20.1