From: Daniel Carl <danielcarl@gmx.de>
Date: Tue, 25 Jun 2013 07:30:33 +0000 (+0200)
Subject: Revert "Don't bubble up click events for hints (#17)."
X-Git-Url: https://git.owens.tech/git.owens.tech/git.owens.tech/git?a=commitdiff_plain;h=1a94bb9194012d7d8fb0b5365b838fe8fce9ead4;p=vimb.git

Revert "Don't bubble up click events for hints (#17)."

This reverts commit 78bfdc4fdee1e84393f268da6ae4d1c24ef291ed.

This patch cause other none usable javascript triggered links. The previous
problem that should be fixed, does also occur if the links are clicked by
mouse so we should try to fix this issue in another place.

It seems that there is a problem if window.open() is triggered in the sites.
---

diff --git a/src/hints.js b/src/hints.js
index 3a6474d..e3f268e 100644
--- a/src/hints.js
+++ b/src/hints.js
@@ -311,7 +311,7 @@ function VimbHints(mode, usage, bg, bgf, fg, style, maxHints)
     function _mouseEvent(e, name)
     {
         var evObj = e.ownerDocument.createEvent("MouseEvents");
-        evObj.initMouseEvent(name, false, true, e.contentWindow, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
+        evObj.initMouseEvent(name, true, true, e.contentWindow, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
         e.dispatchEvent(evObj);
     }