From: Ferenc- <ferenc.gm@gmail.com>
Date: Thu, 18 May 2017 08:58:55 +0000 (+0200)
Subject: Eliminate dead code from main.c
X-Git-Url: https://git.owens.tech/style.css/style.css/git?a=commitdiff_plain;h=9d49420d0728ab966dd289e7c91ea5e908147d65;p=vimb.git

Eliminate dead code from main.c

1. Value stored in 'num' in line 161 was never read
   since it was unconditionally overwritten immediately in 166.

2. Value stored in 'suffix' in line 145 was never read
   since it was overwritten in both branches of 'if(dot_post)'.

3. Value stored in 'req' in line 1157 was never read
   if the branch of the first if statement is taken.
   Storing has been placed int to the second if statement,
   where it is actually used.
---

diff --git a/src/main.c b/src/main.c
index e1116fb..fd77f00 100644
--- a/src/main.c
+++ b/src/main.c
@@ -142,7 +142,6 @@ gboolean vb_download_set_destination(Client *c, WebKitDownload *download,
         GString *tmp;
         gssize suffix;
         int i = 1;
-        suffix = 2;
 
         /* position on .tar. (special case, extension with two dots),
          * position on last dot (if any) otherwise */
@@ -158,7 +157,6 @@ gboolean vb_download_set_destination(Client *c, WebKitDownload *download,
         }
 
         tmp = g_string_new(NULL);
-        num = g_strdup_printf("%d", i++);
 
         /* Construct a new complete download filepath with suffix before the
          * file extension. */
@@ -1154,7 +1152,6 @@ static gboolean on_webview_decide_policy(WebKitWebView *webview,
 
         case WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION:
             a   = webkit_navigation_policy_decision_get_navigation_action(WEBKIT_NAVIGATION_POLICY_DECISION(dec));
-            req = webkit_navigation_action_get_request(a);
 
             /* Ignore opening new window if this was started without user gesture. */
             if (!webkit_navigation_action_is_user_gesture(a)) {
@@ -1167,6 +1164,7 @@ static gboolean on_webview_decide_policy(WebKitWebView *webview,
                 /* This is triggered on link click for links with *
                  * target="_blank". Maybe it should be configurable if the
                  * page is opened as tabe or a new instance. */
+                req = webkit_navigation_action_get_request(a);
                 spawn_new_instance(webkit_uri_request_get_uri(req), TRUE);
                 return TRUE;
             }